Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge): getNonce and setNonce cheatcodes #631

Closed
wants to merge 1 commit into from
Closed

feat(forge): getNonce and setNonce cheatcodes #631

wants to merge 1 commit into from

Conversation

calldata
Copy link
Contributor

@calldata calldata commented Jan 30, 2022 •
edited by gakonst
Loading

Motivation

implement the setNonce/getNonce feature

closes #554

Solution

@calldata
Copy link
Contributor Author

wait for rust-ethereum/evm#92 to be merged

@calldata calldata changed the title (WIP) feat: getNonce and setNonce cheatcodes (WIP) feat: getNonce and setNonce cheatcodes (#554) Jan 30, 2022
@gakonst gakonst closed this in #623 Jan 30, 2022
@onbjerg onbjerg mentioned this pull request Jan 30, 2022
Merged
2 tasks
@onbjerg onbjerg reopened this Jan 30, 2022
@onbjerg onbjerg added the T-feature Type: feature label Jan 30, 2022
@gakonst
Copy link
Member

gakonst commented Feb 7, 2022

@calldata rust-ethereum/evm#92 is now merged!

@calldata
Copy link
Contributor Author

calldata commented Feb 8, 2022

@gakonst where should i expose the account_mut function ?

@calldata calldata changed the title (WIP) feat: getNonce and setNonce cheatcodes (#554) feat(forge): getNonce and setNonce cheatcodes Feb 8, 2022
@calldata calldata marked this pull request as draft February 8, 2022 14:19
@gakonst gakonst force-pushed the master branch 2 times, most recently from dd690ab to bc613e1 Compare February 9, 2022 11:48
@gakonst
Copy link
Member

gakonst commented Feb 12, 2022 •
edited
Loading

Sorry @calldata, my bad. We're now blocked on rust-ethereum/evm#98. The thing I'd do is add a pub fn account_mut(address: Address) -> ... function on MemoryStackOwned which calls self.substate.account_mut, and then call it from your cheatcode

@gakonst
Copy link
Member

gakonst commented Mar 3, 2022

@onbjerg worth adding to the PR for cheats, if easy to add. closing as it doesn't look like we're gonna get the sputnik PR merged anytime soon, and we'll address in the REVM transition

@gakonst gakonst closed this Mar 3, 2022
@onbjerg onbjerg mentioned this pull request Mar 4, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy will be requested when the pull request is marked ready for review grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: getNonce and setNonce cheatcodes
3 participants
@calldata @gakonst @onbjerg