Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ksoroban prove command #20

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Add ksoroban prove command #20

merged 21 commits into from
Aug 13, 2024

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Aug 5, 2024

This adds ksoroban prove to the CLI:

  • ksoroban prove run will run the proofs for the test contract in the current working directory.
  • ksoroban prove view will view the proof id that was saved in the folder specified by --proof-dir and --id

It's currently limited by the symbolic variables it can generate, notably Vec, Map, and Symbol are not constrained properly, but all of the integral variables should be ok.

@gtrepta gtrepta marked this pull request as ready for review August 9, 2024 20:24
Copy link

@virgil-serbanuta virgil-serbanuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although I didn't check everything. Most likely, @bbyalcinkaya should approve, but I can also do that if needed.

My only question is whether run_prove uses the booster or not. I'm guessing that it does not (I may be wrong), so the next question would be if you want to use it.

@gtrepta
Copy link
Contributor Author

gtrepta commented Aug 12, 2024

My only question is whether run_prove uses the booster or not. I'm guessing that it does not (I may be wrong), so the next question would be if you want to use it.

I was trying to determine if the booster is being used when the proof runner is invoked here, but I haven't been able to so far. I of course would like to make sure that the booster is being used, and planned to ask about it when working on the next PR.

@bbyalcinkaya
Copy link
Member

My only question is whether run_prove uses the booster or not. I'm guessing that it does not (I may be wrong), so the next question would be if you want to use it.

Since there are only LLVM (without 'llvm_kompile_type': LLVMKompileType.C) and Haskell in the compile targets, it seems that Booster is not being used.

Copy link
Member

@bbyalcinkaya bbyalcinkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thank you!

@rv-jenkins rv-jenkins merged commit 2ef6bf9 into master Aug 13, 2024
3 checks passed
@rv-jenkins rv-jenkins deleted the prove branch August 13, 2024 09:41
asavienko added a commit that referenced this pull request Sep 4, 2024
* update runners

* update runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants