Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plotting.py #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Plotting.py #47

wants to merge 2 commits into from

Conversation

aquamas
Copy link

@aquamas aquamas commented May 20, 2023

Since we are adding the predicted location x,y,z representing the center of the 3D bounding box,
just need to add half of the height.

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

aquamas added 2 commits May 20, 2023 13:54
Since we are adding the predicted location x,y,z representing the center of the 3D bounding box.
When retrieving ground truth data from kitti labels.
The location describes the geometric center of the 3D object.
(The same that is derived by solving the minimization of the projected error for retrieving \vec{t} )
By saying location[1] -= dimension[0]/2
we derive the geom center point contacting the ground.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant