Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to wasm-bindgen 0.2.93 #17550

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

torokati44
Copy link
Member

Have to keep things consistent by hand with this one.

https://github.com/rustwasm/wasm-bindgen/blob/main/CHANGELOG.md#0293

@torokati44 torokati44 changed the title chore: Update to wasm-bindgen 0.2.93. chore: Update to wasm-bindgen 0.2.93 Aug 17, 2024
@evilpie
Copy link
Collaborator

evilpie commented Aug 18, 2024

I am currently looking into updating web-sys and js-sys so that we can remove --cfg=web_sys_unstable_apis.

@torokati44
Copy link
Member Author

Okay, cool! Is that directly relevant here though? Sorry if I'm missing something, but isn't that a bit independent of this?

Also, wouldn't we have to re-add it for #16794 anyway?

@evilpie
Copy link
Collaborator

evilpie commented Aug 18, 2024

Okay, cool! Is that directly relevant here though? Sorry if I'm missing something, but isn't that a bit independent of this?

Updating wasm-bindgen is a requirement for doing that update.

Also, wouldn't we have to re-add it for #16794 anyway?

You are right, quite annoying.

@torokati44
Copy link
Member Author

Updating wasm-bindgen is a requirement for doing that update.

Okay, so not the other way around at least - meaning, that doesn't block this PR.

You are right, quite annoying.

Yes, we had to go back and forth on this a couple times already, as we were leapfrogging new features with stabilized APIs...

@torokati44
Copy link
Member Author

I am currently looking into updating web-sys and js-sys

Is it okay to go ahead with this one until then?

@torokati44 torokati44 enabled auto-merge (rebase) August 18, 2024 12:38
@torokati44 torokati44 merged commit 84e4270 into ruffle-rs:master Aug 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants