Skip to content

Commit

Permalink
chore: Update to wasm-bindgen 0.2.93.
Browse files Browse the repository at this point in the history
  • Loading branch information
torokati44 committed Aug 18, 2024
1 parent f84fd98 commit 9049d71
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 19 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/release_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,10 @@ jobs:
registry-url: https://registry.npmjs.org

# wasm-bindgen-cli version must match wasm-bindgen crate version.
# Be sure to update in test_web.yml, web/Cargo.toml and web/README.md.
# Be sure to update in test_web.yml, Cargo.toml, web/docker/Dockerfile,
# and web/README.md as well.
- name: Install wasm-bindgen
run: cargo install wasm-bindgen-cli --version 0.2.92
run: cargo install wasm-bindgen-cli --version 0.2.93

# Keep the version number in sync in all workflows,
# and in the extension builder Dockerfile!
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_extension_dockerfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
registry-url: https://registry.npmjs.org

- name: Install wasm-bindgen
run: cargo install wasm-bindgen-cli --version 0.2.92
run: cargo install wasm-bindgen-cli --version 0.2.93

# Keep the version number in sync in all workflows,
# and in the extension builder Dockerfile!
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test_web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ jobs:
save-if: ${{ github.ref == 'refs/heads/master' }}

# wasm-bindgen-cli version must match wasm-bindgen crate version.
# Be sure to update in release_nightly.yml, web/Cargo.toml and web/README.md.
# Be sure to update in release_nightly.yml, Cargo.toml, web/docker/Dockerfile,
# and web/README.md as well.
- name: Install wasm-bindgen
run: cargo install wasm-bindgen-cli --version 0.2.92
run: cargo install wasm-bindgen-cli --version 0.2.93

# Keep the version number in sync in all workflows,
# and in the extension builder Dockerfile!
Expand Down
21 changes: 11 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ num-traits = "0.2.19"
serde = "1.0.207"
thiserror = "1.0"
url = "2.5.2"
wasm-bindgen = "=0.2.92"
# Make sure to match wasm-bindgen-cli version to this everywhere.
wasm-bindgen = "=0.2.93"
walkdir = "2.5.0"
tokio = { version = "1.39.2" }

Expand Down
4 changes: 2 additions & 2 deletions web/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Note that npm 7 or newer is required. It should come bundled with Node.js 15 or

<!-- Be sure to also update the wasm-bindgen-cli version in `.github/workflows/*.yml` and `web/Cargo.toml`. -->

This can be installed with `cargo install wasm-bindgen-cli --version 0.2.92`. Be sure to install this specific version of `wasm-bindgen-cli` to match the version used by Ruffle.
This can be installed with `cargo install wasm-bindgen-cli --version 0.2.93`. Be sure to install this specific version of `wasm-bindgen-cli` to match the version used by Ruffle.

#### Binaryen

Expand Down Expand Up @@ -143,7 +143,7 @@ Pass `--spec <name>` to filter a test based on name. For example, `--spec extern

### Testing tips!
If debugging a failing test, use `await browser.pause(100000);` in the test file to pause it, and don't start the test with `--headless`.
That way you can actually see what's happening, and manually get involved to debug it.
That way you can actually see what's happening, and manually get involved to debug it.

## Structure

Expand Down
4 changes: 3 additions & 1 deletion web/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ RUN mv binaryen-version_118/bin/wasm-opt /usr/local/bin
# Installing Rust using rustup:
RUN wget 'https://sh.rustup.rs' --quiet -O- | sh -s -- -y --profile minimal --target wasm32-unknown-unknown
ENV PATH="/root/.cargo/bin:$PATH"
RUN cargo install wasm-bindgen-cli --version 0.2.92
# wasm-bindgen-cli version must match wasm-bindgen crate version.
# Be sure to update in test_web.yml, release_nightly.yml, Cargo.toml, and web/README.md as well.
RUN cargo install wasm-bindgen-cli --version 0.2.93

# Building Ruffle:
COPY . ruffle
Expand Down

0 comments on commit 9049d71

Please sign in to comment.