Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle 500kb limit, refactor to service impl #5302

Open
wants to merge 4 commits into
base: release/1.38.x
Choose a base branch
from

chore: fix apiservice newline

f1fc997
Select commit
Loading
Failed to load commit list.
Open

chore: handle 500kb limit, refactor to service impl #5302

chore: fix apiservice newline
f1fc997
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

73.47% (+0.06%) compared to 94aa254

View this Pull Request on Codecov

73.47% (+0.06%) compared to 94aa254

Details

Codecov Report

Attention: Patch coverage is 36.11111% with 92 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (94aa254) to head (f1fc997).

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 12.76% 82 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 80.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5302      +/-   ##
==================================================
+ Coverage           73.40%   73.47%   +0.06%     
==================================================
  Files                 424      425       +1     
  Lines               60243    59965     -278     
==================================================
- Hits                44221    44058     -163     
+ Misses              13578    13435     -143     
- Partials             2444     2472      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.