chore: handle 500kb limit, refactor to service impl #5302
+635
−475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.38.x #5302 +/- ##
==================================================
+ Coverage 73.40% 73.47% +0.06%
==================================================
Files 424 425 +1
Lines 60243 59965 -278
==================================================
- Hits 44221 44058 -163
+ Misses 13578 13435 -143
- Partials 2444 2472 +28 ☔ View full report in Codecov by Sentry. |
koladilip
approved these changes
Nov 18, 2024
|
|
||
| output := mockUploader.Upload(&common.AsyncDestinationStruct{ | ||
| ImportingJobIDs: []int64{1, 2, 3}, | ||
| testData := []byte(`{"message":{"body":{"JSON":{"data":{"type":"profile-bulk-import-job","attributes":{"profiles":{"data":[{"type":"profile","attributes":{"email":"[email protected]","first_name":"Testqwe0022","last_name":"user","phone_number":"+919902330123","location":{"address1":"dallas street","address2":"oppenheimer market","city":"delhi","country":"India","ip":"213.5.6.41"},"anonymous_id":"user1","jobIdentifier":"user1:1"}}]}},"relationships":{"lists":{"data":[{"type":"list","id":"list101"}]}}}}}},"metadata":{"jobId":1}}`) |
There was a problem hiding this comment.
can use this from uploadData.jsonl instead of hard coding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On debugging for the issue, we came across the two pointers addressed here.
Linear Ticket
Related to INT-2820, INT-2840
Security