Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _load_textdomain_just_in_time notice in WordPress 6.7 #365

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Fix _load_textdomain_just_in_time notice in WordPress 6.7 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f0c88c9
Merge pull request #361 from rtCamp/develop
Vedant-Gandhi Oct 22, 2024
bd917e8
Merge pull request #363 from rtCamp/feat/add-default-options
Vedant-Gandhi Oct 24, 2024
104c57e
fix: move settings tab in admin to separate function and initialize i…
Vedant-Gandhi Nov 15, 2024
87e780d
refactor: add proper tab in function description.
Vedant-Gandhi Nov 15, 2024
d181862
Merge branch 'master' of https://github.com/rtCamp/nginx-helper into …
Vedant-Gandhi Nov 18, 2024
05ec1a7
Merge pull request #367 from rtCamp/sync/develop-master
Vedant-Gandhi Nov 18, 2024
aef2252
Merge branch 'master' of https://github.com/rtCamp/nginx-helper into …
Vedant-Gandhi Nov 18, 2024
273aa68
refactor: remove extra space.
Vedant-Gandhi Nov 18, 2024
687c116
refactor: remove extra space.
Vedant-Gandhi Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions admin/class-nginx-helper-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ public function __construct( $plugin_name, $version ) {
$this->plugin_name = $plugin_name;
$this->version = $version;

$this->options = $this->nginx_helper_settings();
}

/**
* Initialize the settings tab.
* Required since i18n is used in the settings tab which can be invoked only after init hook since WordPress 6.7
*/
public function initialize_setting_tab() {

/**
* Define settings tabs
*/
Expand All @@ -94,8 +103,6 @@ public function __construct( $plugin_name, $version ) {
),
)
);

$this->options = $this->nginx_helper_settings();
}

/**
Expand Down
2 changes: 1 addition & 1 deletion includes/class-nginx-helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private function define_admin_hooks() {
global $nginx_helper_admin, $nginx_purger;

$nginx_helper_admin = new Nginx_Helper_Admin( $this->get_plugin_name(), $this->get_version() );

$this->loader->add_action( 'init', $nginx_helper_admin, 'initialize_setting_tab' );
// Defines global variables.
if ( ! empty( $nginx_helper_admin->options['cache_method'] ) && 'enable_redis' === $nginx_helper_admin->options['cache_method'] ) {

Expand Down
Loading