Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _load_textdomain_just_in_time notice in WordPress 6.7 #365

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

Vedant-Gandhi
Copy link
Contributor

Description

The aim of this PR is to fix the warning in WordPress 6.7 since the i18n functions were being invoked before the init hook was fired.

Type

  • Bug Fix

Reference Issue

Testing

  • Upgrade your WordPress to version 6.7
  • Open the Nginx Helper Options Page.
  • Install a non-English language translation for the plugin.
  • Set the site language as the one selected above.
  • Once you are on admin dashboard, ensure that there are no warnings displayed.

Example to install a non-English Language:

wp language plugin install nginx-helper ru_RU // Install the Russian Language translation.
wp user meta update 1 locale ru_RU // Change the current user language to russian.

@Vedant-Gandhi Vedant-Gandhi changed the base branch from master to develop November 15, 2024 09:09
@Vedant-Gandhi Vedant-Gandhi reopened this Nov 18, 2024
@Vedant-Gandhi Vedant-Gandhi marked this pull request as ready for review November 18, 2024 07:23
}


Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing, Please remove the additional line before merging the PR.

@Vedant-Gandhi Vedant-Gandhi merged commit a742262 into develop Nov 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants