Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence tests on Windows #1634

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Apr 24, 2024

Summary

Since the logs are noisy due to file not found.

Now, the only remaining failures in tests is #1481, which is genuine, but with this PR, it works better to run tests locally on windows.

The image snapshot error is annoying too, so I skipped it on windows. I opened r-lib/waldo#191 for options.

Basically, render related warnings are silenced on Windows. I would recommend you investigate a bit more if you have time. But gt is generally working well. I think it is safe to ignore these warnings when running tests locally.

It will make contributing in the future a bit easier!

These are mostly in .Rbuildignore, so won't change much. They are only run on CI on Ubuntu. So the only way to get that is locally on Windows.

I also took advantage to do some test refactoring to make the warning testing a bit more explicit

Related GitHub Issues and PRs

Checklist

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit dd78bd1 into rstudio:master Apr 24, 2024
12 checks passed
@olivroy olivroy deleted the skip-img-windows branch June 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants