Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the logs are noisy due to file not found.
Now, the only remaining failures in tests is #1481, which is genuine, but with this PR, it works better to run tests locally on windows.
The image snapshot error is annoying too, so I skipped it on windows. I opened r-lib/waldo#191 for options.
Basically, render related warnings are silenced on Windows. I would recommend you investigate a bit more if you have time. But gt is generally working well. I think it is safe to ignore these warnings when running tests locally.
It will make contributing in the future a bit easier!
These are mostly in .Rbuildignore, so won't change much. They are only run on CI on Ubuntu. So the only way to get that is locally on Windows.
I also took advantage to do some test refactoring to make the warning testing a bit more explicit
Related GitHub Issues and PRs
Checklist
testthat
unit tests totests/testthat
for any new functionality.