Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on R 3.6 + other package cleanup #1731

Merged
merged 26 commits into from
Jun 26, 2024
Merged

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jun 25, 2024

Ready for review! I don't think I will have anything more to add relates to #1626

Summary

Depend on R 3.6 to be able to use features of R and remove workarounds. Not sure if gt fully worked on older versions. isTRUE() is already used in certain places for example. (Note isTRUE() existed before isFALSE()

  • allows for removal of tidy_sub() and tidy_gsub() (for consistency in the codebase, it is possible to simply use gsub() and sub() in most cases.
  • Tested that the tidy_sub(), tidy_gsub() test passed
  • Remove is_false() (isFALSE() introduced in R 3.5.)
  • Allows for removal of register_s3_method(), see https://www.tidyverse.org/blog/2024/01/roxygen2-7-3-0/ for why/ (fiddle a bit with as.tags() in 8b7f9d8

Unrelated

Checklist

FYI, the hard-to-debug failure was due to r-lib/testthat#1646

olivroy added 23 commits June 25, 2024 09:54
… grepl("x", NA) returns FALSE, so no need for `is_false()`
@olivroy olivroy changed the title Depend on R 3.6 Depend on R 3.6 + other package cleanup Jun 25, 2024
@rich-iannone
Copy link
Member

Thanks for all the great work! This is a nice round of cleanups and I agree with everything done here. Will review and merge shortly.

@rich-iannone rich-iannone self-requested a review June 26, 2024 03:52
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit c545dfe into rstudio:master Jun 26, 2024
12 checks passed
@olivroy olivroy deleted the r3.5 branch June 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants