-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on R 3.6 + other package cleanup #1731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grepl("x", NA) returns FALSE, so no need for `is_false()`
…indows before deletion.
… in .Rbuildignore. Follow advice in https://roxygen2.r-lib.org/articles/namespace.html#s3
Thanks for all the great work! This is a nice round of cleanups and I agree with everything done here. Will review and merge shortly. |
rich-iannone
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review! I don't think I will have anything more to add relates to #1626
Summary
Depend on R 3.6 to be able to use features of R and remove workarounds. Not sure if gt fully worked on older versions.
isTRUE()
is already used in certain places for example. (NoteisTRUE()
existed beforeisFALSE()
tidy_sub()
andtidy_gsub()
(for consistency in the codebase, it is possible to simply usegsub()
andsub()
in most cases.tidy_sub()
,tidy_gsub()
test passedis_false()
(isFALSE()
introduced in R 3.5.)register_s3_method()
, see https://www.tidyverse.org/blog/2024/01/roxygen2-7-3-0/ for why/ (fiddle a bit withas.tags()
in 8b7f9d8Unrelated
tidy_grepl()
to tests/testthat/helper.R since unused in code. https://testthat.r-lib.org/articles/special-files.htmlgsub()
totrimws()
for clarity dd5a471gsub()
begin end topaste0()
for clarity e93c5db.gt-package.R
to avoid repetitionChecklist
testthat
unit tests totests/testthat
for any new functionality.FYI, the hard-to-debug failure was due to r-lib/testthat#1646