Fix #279 by removing querying sub callback after subscription is destroyed #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
force-pushed
the
yadu/fix_content_filter_test
branch
from
b56d072 to
2c23184
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/fix_content_filter_test
branch
from
2c23184 to
589e031
Compare
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
approved these changes
Sep 17, 2024
imstevenpmwork
pushed a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Sep 23, 2024
…destroyed (ros2#282) Signed-off-by: Yadunund <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem should not happen once we move all RMW entities into classes and we capture weak_ptrs in lambdas. For now I added an API to erase the querying sub callback. I am able to get the test in #279 to pass. Also tested with the scenario in #263 to make sure thee are no regressions.