Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip rmw zenoh content filtering tests #2627

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Skip rmw zenoh content filtering tests #2627

merged 1 commit into from
Sep 23, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 12, 2024

Content filtering is still not implemented in rmw_zenoh

https://github.com/ros2/rmw_zenoh/blob/60b72f07a7d7254aeed8c39c11174bb52806ee62/rmw_zenoh_cpp/src/rmw_zenoh.cpp#L1690-L1713

These tests generates a segfault, I think we can skip them for now.

@ahcorde
Skip rmw zenoh content filtering tests
8cd43fb 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Sep 12, 2024
fujitatomoya
fujitatomoya approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@Yadunund
Copy link
Member

These tests generates a segfault, I think we can skip them for now.

Is the segfault on the rmw_zenoh side or here? Either way we should ensure we don't segfault anywhere and instead throw appropriate errors? 🤔

@Yadunund
Copy link
Member

@ahcorde do we still need this PR given the fix from ros2/rmw_zenoh#282?

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 23, 2024

@ahcorde do we still need this PR given the fix from ros2/rmw_zenoh#282?

Now I'm getting a different error:

[ RUN      ] TestContentFilterSubscription.content_filter_reset
[WARN] [1727092853.470390122] [rmw_zenoh_cpp]: `reliability` no longer supported on subscriber. Ignoring...
/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_subscription_content_filter.cpp:293: Failure
Value of: receive
  Actual: false
Expected: true

/home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_subscription_content_filter.cpp:200: Failure
Expected equality of these values:
  original_message
    Which is: 48-byte object <00-00 00-CE 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>
  output_message
    Which is: 48-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>

@Yadunund
Copy link
Member

Ah a different error; likely from the fact that we don't implement content filtering in rmw_zenoh. We can skip this test 👍🏼

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 23, 2024

Pulls: #2627
Gist: https://gist.githubusercontent.com/ahcorde/54559c823a8f661ddc5084deec01cd87/raw/2f3750ab8bf77029431661da6a0d1ec58075646d/ros2.repos
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14598

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Yadunund Yadunund merged commit 63105cd into rolling Sep 23, 2024
3 checks passed
@Yadunund Yadunund deleted the ahcorde/rolling/zenoh_content_filtering branch September 23, 2024 18:19
@Yadunund Yadunund mentioned this pull request Sep 26, 2024
Open
3 tasks
@fujitatomoya
Copy link
Collaborator

Pulls: #2627
Gist: https://gist.githubusercontent.com/fujitatomoya/0a7080250e9f3be8258162b4227c0c52/raw/e22e9cb3650abeb4f7bad242a04b31eff1663555/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14833

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Yadunund approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@hidmic hidmic Awaiting requested review from hidmic

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @Yadunund @fujitatomoya