Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Handle simulation environment clocks #1810

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Oct 24, 2024

As there are many ongoing issues that people are trying to use the ros2_control_node for the simulation environments and as it is not working, I wanted to see if this solution is something that we are interesting to go with or we simple reject the possibility

Related to : #859

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (d55def1) to head (bb5f0f1).

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   87.62%   87.61%   -0.01%     
==========================================
  Files         120      120              
  Lines       12217    12226       +9     
  Branches     1093     1094       +1     
==========================================
+ Hits        10705    10712       +7     
- Misses       1123     1124       +1     
- Partials      389      390       +1     
Flag Coverage Δ
unittests 87.61% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 84.21% <66.66%> (-4.03%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which situations would this be useful? When we have a simulator hardware component that doesn't run its own control node such as Gazebo, right?

@saikishor which issues are related to this PR?

@saikishor
Copy link
Member Author

In which situations would this be useful? When we have a simulator hardware component that doesn't run its own control node such as Gazebo, right?

@saikishor which issues are related to this PR?

@fmauch It seems many are using this node alongside IssacSim or other simulators. We should decide what to do in our next WG meeting, either support it this way or throw an exception that it is not supported to use with simulation.

It is related to #859 and ros-controls/ros2_controllers#537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants