-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hardware spawner and add tests for it #1759
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
+ Coverage 86.83% 87.53% +0.69%
==========================================
Files 121 122 +1
Lines 11542 11618 +76
Branches 1054 1054
==========================================
+ Hits 10023 10170 +147
+ Misses 1144 1070 -74
- Partials 375 378 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for fixing this! And yes, we have to backport this. Not many people are using it so it is fine if we do small breakings on user-level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes good to me. One minor comment about the tests and another one to update the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should add the usage of this in the demos. Maybe it suits with ros-controls/ros2_control_demos#417.
And should we also add a load_hardware_component CLI verb?
This basically implements my comments from #1682 (review)
I discussed with @destogl that I would create a new PR including his commit from #1682. So, this effectively replaces #1682.
It basically changes the following things:
is_hardware_component_loaded
checks for one single string, whileactivate_components
andconfigure_components
expect a list.)