-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HW_IF] Prepare the handles for async operations #1750
base: master
Are you sure you want to change the base?
[HW_IF] Prepare the handles for async operations #1750
Conversation
0630604
to
eb8a27b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
- Coverage 87.62% 87.42% -0.20%
==========================================
Files 120 120
Lines 12217 12310 +93
Branches 1093 1105 +12
==========================================
+ Hits 10705 10762 +57
- Misses 1123 1150 +27
- Partials 389 398 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eb8a27b
to
fe121c6
Compare
This pull request is in conflict. Could you fix it @saikishor? |
fe121c6
to
facb6a7
Compare
facb6a7
to
a55dedd
Compare
a55dedd
to
59c642a
Compare
// BEGIN (Handle export change): for backward compatibility | ||
// TODO(Manuel) return value_ if old functionality is removed | ||
THROW_ON_NULLPTR(value_ptr_); | ||
return *value_ptr_; | ||
// END | ||
} | ||
|
||
void set_value(double value) | ||
[[nodiscard]] bool get_value(double & value) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamueluth please check this. This is how we can template the access to variables. This should simplify test changes.
hardware_interface/include/hardware_interface/loaned_command_interface.hpp
Outdated
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/loaned_command_interface.hpp
Show resolved
Hide resolved
…t and get value method with some statistics on misses and timeouts
As with #1688 and #1689 there are not many changes in the handles.hpp file. I think this is the right moment to do it, to have straight away working handles in async. The proposed changes would work with zero overhead in synchronous operations.
Looking forward for your feedback!