Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readd activate_all_components method to not break API #1392

Merged

Conversation

saikishor
Copy link
Member

Readd the activate_all_components method for backward compatibility

Copy link
Contributor

mergify bot commented Feb 14, 2024

@saikishor, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@saikishor saikishor changed the title readd activate_all_components method to not to break API readd activate_all_components method to not break API Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6608dbc) 31.03% compared to head (809a524) 62.38%.
Report is 4 commits behind head on humble.

Additional details and impacted files
@@             Coverage Diff             @@
##           humble    #1392       +/-   ##
===========================================
+ Coverage   31.03%   62.38%   +31.34%     
===========================================
  Files          95       95               
  Lines       10729    10176      -553     
  Branches     7421     7290      -131     
===========================================
+ Hits         3330     6348     +3018     
+ Misses        723      667       -56     
+ Partials     6676     3161     -3515     
Flag Coverage Δ
unittests 62.38% <0.00%> (+31.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hardware_interface/src/resource_manager.cpp 78.46% <0.00%> (+27.91%) ⬆️

... and 79 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!
Just for reference, this was removed with #1064

@bmagyar
Copy link
Member

bmagyar commented Feb 14, 2024

Thank you!

@bmagyar bmagyar merged commit 55610db into ros-controls:humble Feb 14, 2024
14 of 15 checks passed
@saikishor saikishor deleted the readd/activate_all_components branch August 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants