fix the order of loading the parameters in the spawner

[saikishor]

This fixes the issue in the spawner that first loads the controller and then loads the parameters. However, it makes sense for it to first load the parameters and the load the controller. This PR addresses it.

Once this is merged, we won't be needing the PRs : ros-controls/ros2_controllers#795 && ros-controls/ros2_controllers#750

[codecov]

Codecov Report

Merging #1145 (4443cc4) into master (bd6911d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1145   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files          94       94           
  Lines       10838    10838           
  Branches     7419     7419           
=======================================
  Hits         3428     3428           
+ Misses        804      803    -1     
- Partials     6606     6607    +1     

Flag	Coverage Δ
unittests	31.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[christophfroehlich]

We should think of integration tests for the ros2_controllers, using the spawner with a default parameter yaml file.

[saikishor]

We should think of integration tests for the ros2_controllers, using the spawner with a default parameter yaml file.

Agreed!

[saikishor]

It seems like this cannot be used as there will be problem loading the parameters. Instead as discussed with @christophfroehlich in a private chat, we have to check with the generate_parameter_library if we can separate declaration and also retrieving of the parameters