Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to admonishment against import(<pkg>) usage #170

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add to admonishment against import(<pkg>) usage #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ed699
Add to admonishment against import(<pkg>) usage
MichaelChirico Sep 25, 2024
90b0bd1
Suggested wording
MichaelChirico Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/chk_namespace.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ CHECKS$no_import_package_as_a_whole <- make_check(
preps = "namespace",

gp = 'not import packages as a whole, as this can cause name
clashes between the imported packages. Instead, import
only the specific functions you need.',
clashes between the imported packages, especially over time as packages change.
Instead, import only the specific functions you need.',

check = function(state) {
if(inherits(state$namespace, "try-error")) return(NA)
Expand Down