[Backport][TMVA] Fix unused variable warnings #13836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix warnings due to an unused variable in non-debug builds.
|
Starting build on |
dpiparo
changed the title
pcanal
reviewed
Oct 10, 2023
| @@ -196,7 +196,7 @@ class TCpuTensor : public TMVA::Experimental::RTensor<AFloat, TCpuBuffer<AFloat> | |||
| //this will be an unsafe view. Method exists for backwards compatibility only | |||
| TCpuMatrix<AFloat> GetMatrix() const | |||
| { | |||
| size_t ndims = 0; | |||
| [[maybe_unused]] size_t ndims = 0; | |||
There was a problem hiding this comment.
I think the warning is actually correct, running the loop be low is pointless if the assert is off. I would consider using:
assert( [&shape]() { int ndims; for (auto& shape_i : shape) { if (shape_i != 1) { ndims++; } }; return ndims; } () <= 2 && shape.size() > 1); // to support shape cases {n,1}
(alternative use a [[maybe_unused]] variable for the lambda).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP of #13835 . The usage of the annotation is possible since for 6.30 cpp17 is enforced.