[TMVA] Work around warning about unused variables #13837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in non-debug builds.
|
Starting build on |
pcanal
reviewed
Oct 10, 2023
| @@ -205,6 +205,7 @@ class TCpuTensor : public TMVA::Experimental::RTensor<AFloat, TCpuBuffer<AFloat> | |||
| } | |||
| } | |||
| assert(ndims <= 2 && shape.size() > 1); // to support shape cases {n,1} | |||
| (void) ndims; // avoid warning about unused variable | |||
There was a problem hiding this comment.
See #13836 (comment)
Side note:
Suggested change
| (void) ndims; // avoid warning about unused variable | |
| (void) sizeof(ndims); // avoid warning about unused variable |
is a more generic version of the pattern used here with a guarantee of no side effect no matter what the type of the variable is.
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the same functionality of #13835, but without using cpp17 functionality.