Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeql and github token permissions #403

Closed
wants to merge 2 commits into from

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Jul 9, 2024

Description of the change

Fix warnings and update to v2.

Error: This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/
Warning: 2 issues were detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results. Please make sure that every branch in on.pull_request is also in on.push so that Code Scanning can compare pull requests against the state of the base branch.

Also fixes a github token permissions issue as described in github/codeql#8843 .

Type of change

  • Maintenance

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9864063504

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.097%

Totals Coverage Status
Change from base Build 8908048250: 0.0%
Covered Lines: 1480
Relevant Lines: 1607

💛 - Coveralls

Copy link

codeclimate bot commented Jul 9, 2024

Code Climate has analyzed commit c69b319 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.0% (0.0% change).

View more on Code Climate.

@waltjones waltjones changed the title try to fix codeql Update codeql and github token permissions Jul 9, 2024
@pawelsz-rb
Copy link
Collaborator

this change was applied in PR #402 , thank you for fixing it.

@pawelsz-rb pawelsz-rb closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants