Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "enabled" field for notification rule #402

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Jul 9, 2024

Description of the change

Added enabled boolean field (true/false) for rule notification.
The change is backward compatible; disabled rule (enabled = false) will not be triggered.

The field is set to true by default.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9879943504

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.097%

Totals Coverage Status
Change from base Build 8908048250: 0.0%
Covered Lines: 1480
Relevant Lines: 1607

💛 - Coveralls

pawelsz-rb and others added 3 commits July 9, 2024 09:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pawelsz-rb pawelsz-rb requested a review from waltjones July 10, 2024 03:10
Copy link

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me, but I'm neither knowledgeable enough in Go nor Terraform to give a confident approval. So I'll wait for @waltjones to give it a look, too.

# the head of the pull request instead of the merge commit.
- run: git checkout HEAD^2
if: ${{ github.event_name == 'pull_request' }}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes necessary? Incl. removing the on push branches/tags (L5-6), and adding permissions (L14-18).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merging @waltjones changes from PR #403

pawelsz-rb and others added 4 commits July 10, 2024 11:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codeclimate bot commented Jul 10, 2024

Code Climate has analyzed commit d4d5339 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.0% (0.0% change).

View more on Code Climate.

@pawelsz-rb pawelsz-rb merged commit dda6fa2 into master Jul 10, 2024
21 checks passed
@pawelsz-rb pawelsz-rb deleted the pawel/added_rule_enabled_field branch July 10, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants