Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making project access token sensitive #391

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Mar 22, 2024

Description of the change

making project access token sensitive. Notice now access token is not displayed to the user in the terraform plan, apply or destroy:

 # rollbar_project_access_token.test_1 will be created
  + resource "rollbar_project_access_token" "test_1" {
      + access_token                = (sensitive value)
      + cur_rate_limit_window_count = (known after apply)
      + cur_rate_limit_window_start = (known after apply)
      + date_created                = (known after apply)
      + date_modified               = (known after apply)
      + id                          = (known after apply)
      + name                        = "test-token-1"
      + project_id                  = 222222222222222222
      + rate_limit_window_count     = 500
      + rate_limit_window_size      = 60
      + scopes                      = [
          + "post_client_item",
        ]
      + status                      = "enabled"
    }

if the users intentionally want to see a sensitive variable, they can use:
terraform show --json

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

relates to PR #384

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8386010945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.097%

Totals Coverage Status
Change from base Build 8170248558: 0.0%
Covered Lines: 1480
Relevant Lines: 1607

💛 - Coveralls

Copy link

codeclimate bot commented Mar 22, 2024

Code Climate has analyzed commit f67f8dd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.0% (0.0% change).

View more on Code Climate.

@pawelsz-rb pawelsz-rb requested review from alif and waltjones March 22, 2024 05:41
@pawelsz-rb pawelsz-rb merged commit 06ebfc8 into master Mar 22, 2024
19 checks passed
@pawelsz-rb pawelsz-rb deleted the pawel/make_access_token_sensitive branch March 22, 2024 17:55
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants