Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_token should be marked as a sensitive value. #384

Closed

Conversation

marcelobartsch-jt
Copy link

@marcelobartsch-jt marcelobartsch-jt commented Nov 8, 2023

Description of the change

access_token is not marked as sensitive, and this value is, as if the access_token is leaked while planning, as with this token, people can inject data to rollbar, it should be marked as sensitive to avoid unintentional leaks.

I'm marking as Breaking change , as depending on how the code is used, it may require to call nonsensitive function , but

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb
Copy link
Collaborator

duplicate of #391

@pawelsz-rb
Copy link
Collaborator

pawelsz-rb commented Mar 22, 2024

@marcelobartsch , it's included in the new release 1.14.0. Thank you for flagging it.

@overdrive3000
Copy link

Based on the creation date looks like the duplicated one is the #391 instead of this one. Thanks anyway to fix it.

@marcelobartsch-jt marcelobartsch-jt deleted the token-sensitive branch April 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants