feat: Prev() function derives the previous time a SpecSchedule would have triggered #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed on time passed in
…lso copy/pasted in error; also add test cases
juliev0
changed the title
… test for Sao Paolo later, however Signed-off-by: Julie Vogelman <[email protected]>
…xt() function Signed-off-by: Julie Vogelman <[email protected]>
gravufo
reviewed
Mar 7, 2022
| @@ -174,6 +174,103 @@ WRAP: | |||
| return t.In(origLocation) | |||
| } | |||
|
|
|||
| // Prev returns the previous time this schedule is activated, less than the given | |||
| // time. If no time can be found to satisfy the schedule, return the zero time. | |||
| func (s *SpecSchedule) Prev(t time.Time) time.Time { | |||
There was a problem hiding this comment.
Not sure if it was wanted or not, but this function should be added to the Schedule interface for it to be accessible externally.
There was a problem hiding this comment.
Okay, I'll add it to the interface and to the ConstantDelaySchedule struct.
There was a problem hiding this comment.
There hasn't been any contribution to the repo since 2020 so let's hope that someone merges this! Thanks for implementing it though
…ntDelaySchedule struct Signed-off-by: Julie Vogelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 322 requested this function to derive the previous time that a SpecSchedule would have triggered.
I am open to moving the logic if you think I should.
Also, I am not sure if it works in the Sao Paolo case. I was having trouble understanding that one in SpecSchedule.Next() in the code and test.