Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cron schedule Contains check #4

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

ChanceLi
Copy link
Contributor

No description provided.

@ChanceLi ChanceLi self-assigned this Aug 15, 2024
@ChanceLi ChanceLi requested a review from oif August 15, 2024 08:19
@ChanceLi ChanceLi force-pushed the fix/fix-cron-schedule-contains-check branch from e4a6912 to db7b4a1 Compare August 19, 2024 02:32
utils/timerange/cron_test.go Outdated Show resolved Hide resolved
@ChanceLi ChanceLi force-pushed the fix/fix-cron-schedule-contains-check branch from db7b4a1 to 457fc17 Compare August 19, 2024 10:28
@ChanceLi
Copy link
Contributor Author

单测确认 robfig/cron#437 实现可行,先替换

原有实现也不 squash 掉,万一有啥问题快速能回退

@ChanceLi ChanceLi force-pushed the fix/fix-cron-schedule-contains-check branch from fffad35 to 5841645 Compare August 20, 2024 06:14
@oif
Copy link
Contributor

oif commented Aug 21, 2024

LGTM

@oif oif merged commit 9949da4 into main Aug 21, 2024
@oif oif deleted the fix/fix-cron-schedule-contains-check branch August 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants