Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isMultiple check by adding compare with false #3811

Merged
merged 3 commits into from
Sep 1, 2023
Merged

fix isMultiple check by adding compare with false #3811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f3bc94
fix isMultiple check by adding compare with false
antpaw Aug 4, 2023
4abec63
Update CHANGELOG.md
antpaw Sep 1, 2023
4b2098e
Update CHANGELOG.md
nickgros Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ should change the heading of the (upcoming) version to include a major version b

- Updated `MultiSchemaField` to only merge top level required field fixing duplicate field and description.

## @rjsf/chakra-ui

- Fixed a faulty check of the `isMultiple` option in `MultiSchemaField`. It no longer offers multiple choice inside a select field in a `oneOf` case in Chakra UI, fixing [#3848](https://github.com/rjsf-team/react-jsonschema-form/issues/3848)

# 5.12.1

## @rjsf/validator-ajv8
Expand Down
2 changes: 1 addition & 1 deletion packages/chakra-ui/src/SelectWidget/SelectWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default function SelectWidget<T = any, S extends StrictRJSFSchema = RJSFS
})
: [];

const isMultiple = typeof multiple !== 'undefined' && Boolean(enumOptions);
const isMultiple = typeof multiple !== 'undefined' && multiple !== false && Boolean(enumOptions);
antpaw marked this conversation as resolved.
Show resolved Hide resolved
const selectedIndex = enumOptionsIndexForValue<S>(value, enumOptions, isMultiple);
const formValue: any = isMultiple
? ((selectedIndex as string[]) || []).map((i: string) => {
Expand Down