-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix isMultiple check by adding compare with false #3811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
previously requested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and update the CHANGELOG.md
@antpaw Just a little bit more work and we can get this over the line |
antpaw
force-pushed
the
fix-mulitple-select
branch
from
August 24, 2023 06:39
84bbdf3
to
f9e1088
Compare
antpaw
force-pushed
the
fix-mulitple-select
branch
from
August 29, 2023 07:11
f9e1088
to
3f3bc94
Compare
This was referenced Aug 31, 2023
nickgros
reviewed
Sep 1, 2023
Co-authored-by: Nick Grosenbacher <[email protected]>
nickgros
reviewed
Sep 1, 2023
nickgros
approved these changes
Sep 1, 2023
Looks good, thanks @antpaw ! I will merge this as soon as it passes and we'll release 5.12.2 soon! |
nickgros
dismissed
heath-freenome’s stale review
September 1, 2023 13:14
Requested changes were made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This fixes the issue where chakra-ui would render a multiselect for a
oneOf
field selectChecklist
npm run test:update
to update snapshots, if needed.