-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change servers page wording #337
Closed
jog1t
wants to merge
1
commit into
09-21-fix_change_how_billing_are_calculated
from
09-21-fix_change_servers_page_wording
Closed
fix: change servers page wording #337
jog1t
wants to merge
1
commit into
09-21-fix_change_how_billing_are_calculated
from
09-21-fix_change_servers_page_wording
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hub with Cloudflare Pages
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 21, 2024
Closed
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
September 21, 2024 16:45
62cc280
to
e9a3cc8
Compare
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
September 21, 2024 16:45
33d42da
to
6b063d6
Compare
This was referenced Sep 22, 2024
Closed
NathanFlurry
approved these changes
Sep 24, 2024
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
September 25, 2024 13:36
e9a3cc8
to
45e373b
Compare
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
September 25, 2024 13:36
6b063d6
to
f8d6bba
Compare
Closed
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
September 25, 2024 14:04
45e373b
to
7415e72
Compare
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
September 25, 2024 14:04
f8d6bba
to
06fab23
Compare
This was referenced Sep 25, 2024
Closed
Closed
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
September 25, 2024 22:26
7415e72
to
cc680c9
Compare
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
September 25, 2024 22:26
06fab23
to
aefc822
Compare
Merge activity
|
jog1t
added a commit
that referenced
this pull request
Sep 26, 2024
Closes CON-69 ### TL;DR Updated the message displayed when no servers are found in the game environment. ### What changed? Modified the text shown to users when there are no servers in the game environment. Instead of simply stating "No servers found.", the new message informs users that "Servers will be created automatically when players join." ### How to test? 1. Navigate to a game environment with no active servers. 2. Verify that the new message "Servers will be created automatically when players join." is displayed in the server list area. ### Why make this change? This change provides more informative feedback to users, explaining the automatic server creation process when players join. It helps set expectations and reduces potential confusion about why no servers are initially visible in the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CON-69
TL;DR
Updated the message displayed when no servers are found in the game environment.
What changed?
Modified the text shown to users when there are no servers in the game environment. Instead of simply stating "No servers found.", the new message informs users that "Servers will be created automatically when players join."
How to test?
Why make this change?
This change provides more informative feedback to users, explaining the automatic server creation process when players join. It helps set expectations and reduces potential confusion about why no servers are initially visible in the environment.