fix: change how billing are calculated #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hub with
|
| Latest commit: |
cc680c9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7dea2dc.hub-3av.pages.dev |
| Branch Preview URL: | https://09-21-fix-change-how-billing.hub-3av.pages.dev |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 21, 2024
Closed
jog1t
force-pushed
the
08-31-feat_modules_tab
branch
from
69c17de
to
70c123a
Compare
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
62cc280
to
e9a3cc8
Compare
This was referenced Sep 22, 2024
Closed
NathanFlurry
approved these changes
Sep 24, 2024
jog1t
force-pushed
the
08-31-feat_modules_tab
branch
from
70c123a
to
ac9240a
Compare
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
e9a3cc8
to
45e373b
Compare
Closed
jog1t
force-pushed
the
08-31-feat_modules_tab
branch
from
ac9240a
to
ca670ea
Compare
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
45e373b
to
7415e72
Compare
This was referenced Sep 25, 2024
Closed
Closed
jog1t
force-pushed
the
09-21-fix_change_how_billing_are_calculated
branch
from
7415e72
to
cc680c9
Compare
Merge activity
|
jog1t
added a commit
that referenced
this pull request
Sep 26, 2024
Closes CON-70 ### TL;DR Updated billing calculations and display for game plans. ### What changed? - Added a `total` field to the `GameBillingContextValue` interface - Updated `GameBillingPlans` component to use dynamic pricing from `PRICE_MAP` - Modified `GameBillingSummary` to display the total bill instead of overage - Introduced `PRICE_MAP` in `billing-calculate-usage.ts` for plan pricing - Updated `calculateUsedCredits` function to include total bill calculation ### How to test? 1. Navigate to the game billing section 2. Verify that the pricing for Indie and Studio plans is correctly displayed 3. Check that the "Current bill total" in the billing summary shows the correct total (base plan price + overage) 4. Test different usage scenarios to ensure the total bill is calculated correctly ### Why make this change? This change improves the accuracy and clarity of billing information for users. By introducing dynamic pricing and displaying the total bill (including the base plan price), users can better understand their current charges and make informed decisions about their subscription plans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CON-70
TL;DR
Updated billing calculations and display for game plans.
What changed?
totalfield to theGameBillingContextValueinterfaceGameBillingPlanscomponent to use dynamic pricing fromPRICE_MAPGameBillingSummaryto display the total bill instead of overagePRICE_MAPinbilling-calculate-usage.tsfor plan pricingcalculateUsedCreditsfunction to include total bill calculationHow to test?
Why make this change?
This change improves the accuracy and clarity of billing information for users. By introducing dynamic pricing and displaying the total bill (including the base plan price), users can better understand their current charges and make informed decisions about their subscription plans.