Use more_info_url from v1 API as link button destination #150
Conversation
## Description The links to the RA pages about the IRA incentives are currently in `item.url`, which doesn't make conceptual sense. We're going to move them to a new `more_info_url` field on incentives, and make `program_url` required. We'll have The backend is currently not sending `more_info_url` in v1 at all, so this PR will be a no-op when it's deployed. After the backend change is deployed, I'll follow up by removing `item.url` from the frontend, and then from the backend. ## Test Plan Run against the prod backend and make sure the IRA incentives have link buttons with the same contents and URL as before. Run against a local backend with the `more_info_url` change applied; make sure the frontend continues to have exactly the same behavior. (It used to be that the IRA incentives had no program URL, so the buttons used the item URL. Now they do have a program URL, but they all have a more-info URL that is exactly the same as the item URL.)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Backend PR: rewiringamerica/api.rewiringamerica.org#386 |
There was a problem hiding this comment.
Run against the prod backend and make sure the IRA incentives have
link buttons with the same contents and URL as before.
this worked as expected, no changes in link behavior
Run against a local backend with the more_info_url change applied;
make sure the frontend continues to have exactly the same
behavior
this isn't working - when I tested locally with the backend changes, all of the IRA tax credit incentives were pointing to irs.gov rather than the homes.- links
edit: tested again and it is working! ignore
|
Right, so when I deploy this PR it'll be a no-op. Then when I deploy the first backend change, the more info URLs will be in both item.url and more_info_url, and the frontend will use the latter. Then there'll be a frontend change to assume program_url is always defined, and stop using item.url. Finally, a backend change to drop item.url. |
## Description Followup to #150. This will let us remove item URLs from v1 if we want. ## Test Plan This should be a no-op; the removed case should never be hit now that program_url is required. Submit the form for a RI zip code and look at HVAC incentives; make sure the non-IRA ones still say "visit site" and the IRA ones say "learn more" and link to the homes.rewiring pages.
## Description Followup to #150. This will let us remove item URLs from v1 if we want. ## Test Plan This should be a no-op; the removed case should never be hit now that program_url is required. Submit the form for a RI zip code and look at HVAC incentives; make sure the non-IRA ones still say "visit site" and the IRA ones say "learn more" and link to the homes.rewiring pages.
## Description Followup to #150. This will let us remove item URLs from v1 if we want. ## Test Plan This should be a no-op; the removed case should never be hit now that program_url is required. Submit the form for a RI zip code and look at HVAC incentives; make sure the non-IRA ones still say "visit site" and the IRA ones say "learn more" and link to the homes.rewiring pages.
Description
The links to the RA pages about the IRA incentives are currently in
item.url, which doesn't make conceptual sense. We're going to movethem to a new
more_info_urlfield on incentives, and makeprogram_urlrequired. We'll haveThe backend is currently not sending
more_info_urlin v1 at all, sothis PR will be a no-op when it's deployed. After the backend change
is deployed, I'll follow up by removing
item.urlfrom the frontend,and then from the backend.
Test Plan
Run against the prod backend and make sure the IRA incentives have
link buttons with the same contents and URL as before.
Run against a local backend with the
more_info_urlchange applied;make sure the frontend continues to have exactly the same
behavior. (It used to be that the IRA incentives had no program URL,
so the buttons used the item URL. Now they do have a program URL, but
they all have a more-info URL that is exactly the same as the item
URL.)