Stop using item.url; make program_url required #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rpartridge
approved these changes
Mar 26, 2024
veekas
approved these changes
Mar 26, 2024
## Description Followup to #150. This will let us remove item URLs from v1 if we want. ## Test Plan This should be a no-op; the removed case should never be hit now that program_url is required. Submit the form for a RI zip code and look at HVAC incentives; make sure the non-IRA ones still say "visit site" and the IRA ones say "learn more" and link to the homes.rewiring pages.
oyamauchi
force-pushed
the
owen.more-info-2
branch
from
fe971ee to
6cb741d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #150. This will let us remove item URLs from v1 if we want.
Test Plan
This should be a no-op; the removed case should never be hit now that
program_url is required. Submit the form for a RI zip code and look at
HVAC incentives; make sure the non-IRA ones still say "visit site" and
the IRA ones say "learn more" and link to the homes.rewiring pages.