Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecommerce to work with new runtime and service ports #86

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix ecommerce to work with new runtime and service ports #86

merged 2 commits into from
Feb 1, 2024

Conversation

gvdongen
Copy link
Collaborator

@gvdongen gvdongen commented Feb 1, 2024

  • Fixed docker compose setups with and without PG
  • Fixed knative deployment
  • Removed AWS deployment option: not relevant anymore with Restate CDK. Outdated way of doing it. Maybe in the future we can make this demo deployable with CDK

@gvdongen gvdongen requested a review from igalshilman February 1, 2024 10:58
igalshilman
igalshilman approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gvdongen, looks good!

@gvdongen gvdongen merged commit b1f87aa into main Feb 1, 2024
2 checks passed
@gvdongen gvdongen deleted the fix_ecommerce branch February 1, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvdongen @igalshilman