Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Custom Delegation endpoints #689

Merged
merged 9 commits into from
Sep 14, 2024
Merged

feat: Custom Delegation endpoints #689

merged 9 commits into from
Sep 14, 2024

Conversation

kairoaraujo
Copy link
Member

@kairoaraujo kairoaraujo commented Sep 8, 2024 •
edited
Loading

Description

This adds a set of endpoints to enable users to manage Custom Delegations

  • Add support to the POST /api/v1/bootstrap to the user define RSTUF to use Delegation Roles creating the initial Delegations
  • Add POST /api/v1/delegations to add new custom delegation roles
  • Add PUT /api/v1/delegations to update the custom delegation roles
  • Add POST /api/v1/delegations/delete to delete custom delegation roles

This PR requires repository-service-tuf/repository-service-tuf-worker#593

Notes:

  • This PR doesn't break the compatibility with BINS, as can be checked in the functional tests
    TODO:
  • Add unit tests (We want to prioritize the FT and later add unit test for developments for this feature)

Fixes #(issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

@kairoaraujo kairoaraujo mentioned this pull request Sep 8, 2024
Closed
7 tasks
@kairoaraujo
feat: add support for bootstrap with custom delegated roles
625e179 
Add support the bootstrap API to access custom delegated roles

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
feat: add support to add new delegated roles
a4487d6 
This commit enables to submit new delegated roles to the API

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
feat: delete custom delegated roles API
a6ca89d 
Allows users to remove custom delegation roles.

Signed-off-by: Kairo Araujo <[email protected]>
@kairoaraujo
feat: add endpoint for updating custom delegation
52b6e24 
PUT endpoint that allows user the update the custom delegations

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
refactor: split the delegations to a tag
e3c3e30 
Add specific tag for delegations

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
fix: signing for error handle
0cf240a 
Signed-off-by: Kairo de Araujo <[email protected]>

custom-delegated-targets-offline-keys'.

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
tests: handle tests for the new features
530dc12 
Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo
docs: update API documentation
9c08036 
Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo kairoaraujo force-pushed the feat/custom-delegated-targets-offline-keys branch from ab88455 to 9c08036 Compare September 8, 2024 01:57
MVrachev
MVrachev requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@MVrachev MVrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You no longer need metadata_delegation inside repository_service_tuf_api/metadata.py. Please delete it.

Also, please create an issue for the missing unit tests.

After those two things I am ready to approve.

@kairoaraujo
fix: remove unecessary duplicate function
3eaeaa8 
not required metadata_delegation function was deleted

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo kairoaraujo force-pushed the feat/custom-delegated-targets-offline-keys branch from 2de5ee7 to 3eaeaa8 Compare September 14, 2024 08:00
@MVrachev MVrachev merged commit 97fa27f into main Sep 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MVrachev MVrachev MVrachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kairoaraujo @MVrachev