Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Custom Delegation Roles API endpoints #688

Conversation

kairoaraujo
Copy link
Member

Description

Add endpoints to support Custom Delegation Roles.

It is related:

  1. feat: Custom Delegation(Target) Roles repository-service-tuf-worker#592
  2. FT: Custom Delegation Roles repository-service-tuf#817

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

  • [~] Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Add support the bootstrap API to access custom delegated roles

Signed-off-by: Kairo de Araujo <[email protected]>
This commit enables to submit new delegated roles to the API

Signed-off-by: Kairo de Araujo <[email protected]>
Allows users to remove custom delegation roles.

Signed-off-by: Kairo Araujo <[email protected]>
PUT endpoint that allows user the update the custom delegations

Signed-off-by: Kairo de Araujo <[email protected]>
Add specific tag for delegations

Signed-off-by: Kairo de Araujo <[email protected]>
Signed-off-by: Kairo de Araujo <[email protected]>

custom-delegated-targets-offline-keys'.

Signed-off-by: Kairo de Araujo <[email protected]>
Signed-off-by: Kairo de Araujo <[email protected]>
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 30 lines in your changes missing coverage. Please review.

Project coverage is 94.45%. Comparing base (25928b7) to head (ab88455).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
repository_service_tuf_api/metadata.py 66.66% 11 Missing ⚠️
repository_service_tuf_api/delegations.py 73.68% 10 Missing ⚠️
repository_service_tuf_api/common_models.py 66.66% 4 Missing ⚠️
repository_service_tuf_api/api/delegations.py 75.00% 3 Missing ⚠️
repository_service_tuf_api/bootstrap.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   98.97%   94.45%   -4.53%     
==========================================
  Files          14       16       +2     
  Lines         588      758     +170     
==========================================
+ Hits          582      716     +134     
- Misses          6       42      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo
Copy link
Member Author

Supressed by #689 that shows FT.

@kairoaraujo kairoaraujo closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant