[#2001] Extract c-file-type-checkboxes from Summary, Authorship and Zoom #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckcherry23
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM! Thanks for the refactor @sopa301! I think we can merge this once the new file is renamed.
sopa301
changed the title
|
The following links are for previewing this pull request:
|
ckcherry23
reviewed
May 15, 2024
Comment on lines
+103
to
+105
| return `${label.fileType}\xA0\xA0` | ||
| + `${label.blankLineCount}\xA0\xA0` | ||
| + `(${label.lineCount - label.blankLineCount})\xA0`; |
There was a problem hiding this comment.
@sopa301 This must be showing "Line count (Line count - blank line count)", but this is "Blank line count (Line count - blank line count)" instead.
Suggested change
| return `${label.fileType}\xA0\xA0` | |
| + `${label.blankLineCount}\xA0\xA0` | |
| + `(${label.lineCount - label.blankLineCount})\xA0`; | |
| return `${label.fileType}\xA0\xA0` | |
| + `${label.lineCount}\xA0\xA0` | |
| + `(${label.lineCount - label.blankLineCount})\xA0`; |
There was a problem hiding this comment.
Oops, I'll create a PR to fix it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2001.
Proposed commit message
Other information
Progress: