Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkboxes showing the wrong line counts #2222

Closed
sopa301 opened this issue May 18, 2024 · 0 comments · Fixed by #2223
Closed

Checkboxes showing the wrong line counts #2222

sopa301 opened this issue May 18, 2024 · 0 comments · Fixed by #2223
Assignees
@sopa301
Labels
a-FrontEnd c.Bug

Comments

@sopa301
Copy link
Contributor

sopa301 commented May 18, 2024 •
edited by ckcherry23
Loading

In c-file-type-checkboxes, the method getLabel() should show fileType, lineCount and effective line count, but it currently shows fileType, blankLineCount and effective line count instead.

From #2173 (comment).
@sopa301 sopa301 self-assigned this May 18, 2024
@sopa301 sopa301 mentioned this issue May 18, 2024
Merged
ckcherry23 pushed a commit that referenced this issue May 18, 2024
@sopa301
[#2222] Fix Checkboxes Line Count (#2223)
7d7a5a9 
Fix Checkboxes Line Count

In c-file-type-checkboxes, the method getLabel() should show fileType,
lineCount and effective line count, but it currently shows fileType,
blankLineCount and effective line count instead.

Let's fix the code to show the correct counts.
@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sopa301 sopa301

Labels
a-FrontEnd c.Bug
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2222] Fix Checkboxes Line Count sopa301/RepoSense
1 participant
@sopa301