-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2148] Show tags on the ramp chart #2163
Merged
sopa301
merged 30 commits into
reposense:master
from
jonasongg:add-show-tags-on-ramp-chart
Apr 27, 2024
Merged
Changes from 11 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
356846a
show all tags of repo
jonasongg 82a3c20
add checkbox to toggle showing of repo tags
jonasongg ed0f2a5
add newline
jonasongg a4f3d41
fix lint
jonasongg 05e2ba6
change view repo tags checkbox to show tags
jonasongg 4989606
update documentation
jonasongg c22f1cf
add tests for show tags on ramp chart
jonasongg 154d624
add show tags test
jonasongg feeb20a
add link to tags in show tags
jonasongg dea2fe5
add test for redirecting to opening tag
jonasongg fea42a1
fix lint
jonasongg ee8c74c
fix show tags when sort by authors
jonasongg c4a4b02
add view repo tags to the hash
jonasongg 3b17857
fix logic for getting tags
jonasongg 9347db8
fix lint
jonasongg 0e177cb
Merge remote-tracking branch 'upstream/master' into add-show-tags-on-…
jonasongg 875c335
extract showTags v-ifs into computed booleans
jonasongg dcc5a73
Merge remote-tracking branch 'upstream/master' into add-show-tags-on-…
jonasongg 6eb18f4
merge
jonasongg 1537302
add show tags to renderFilterHash test
jonasongg 1a6213d
Merge branch 'master' into add-show-tags-on-ramp-chart
jonasongg d6733a4
fix getTagLink for viewing tags for author
jonasongg 5e786a2
Merge remote-tracking branch 'refs/remotes/origin/add-show-tags-on-ra…
jonasongg 0f208d3
Merge remote-tracking branch 'upstream/master' into add-show-tags-on-…
jonasongg e1cd222
Merge branch 'master' into add-show-tags-on-ramp-chart
jonasongg cf06707
fix showTags cypress test
jonasongg 98f3be7
Merge branch 'master' into add-show-tags-on-ramp-chart
jonasongg 3832b3c
fix failing cypress
jonasongg a481255
fix cypress
jonasongg 37b4b88
Merge branch 'master' into add-show-tags-on-ramp-chart
sopa301 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
describe('show tags', () => { | ||
it('unchecked should not display any tags for a group', () => { | ||
cy.get('#summary label.show-tags > input:visible') | ||
.should('be.visible') | ||
.uncheck() | ||
.should('not.be.checked'); | ||
|
||
cy.get('.summary-charts__title--tags') | ||
.should('not.exist'); | ||
}); | ||
|
||
it('checked should display all tags for a group', () => { | ||
cy.get('#summary label.show-tags > input:visible') | ||
.should('be.visible') | ||
.check() | ||
.should('be.checked'); | ||
|
||
cy.get('#summary label.merge-group > input:visible') | ||
.should('be.visible') | ||
.check() | ||
.should('be.checked'); | ||
|
||
cy.get('.icon-button.fa-list-ul') | ||
.should('exist') | ||
.first() | ||
.click(); | ||
|
||
const correctTags = []; | ||
|
||
cy.get('.zoom__title--tags') | ||
.find('.tag') | ||
.each(($tag) => correctTags.push($tag.text().trim())).then(() => { | ||
cy.get('.summary-charts__title--tags') | ||
.find('.tag') | ||
.each(($tag) => { | ||
expect(correctTags).to.include($tag.text().trim()); | ||
}); | ||
|
||
cy.get('.summary-charts__title--tags') | ||
.find('.tag') | ||
.should('have.length', correctTags.length); | ||
}); | ||
}); | ||
|
||
it('clicked should redirect to the correct tag page', () => { | ||
cy.get('#summary label.show-tags > input:visible') | ||
.should('be.visible') | ||
.check() | ||
.should('be.checked'); | ||
|
||
cy.get('.summary-charts__title--tags') | ||
.find('.tag') | ||
.first() | ||
.invoke('removeAttr', 'target') // to open in the same window | ||
.click(); | ||
|
||
cy.origin('https://github.com', () => { | ||
cy.url() | ||
.should('equal', 'https://github.com/reposense/RepoSense/releases/tag/v1.0'); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
@import 'colors'; | ||
|
||
/* Tags in commits */ | ||
.tag { | ||
@include mini-font; | ||
background: mui-color('grey', '600'); | ||
border-radius: 5px; | ||
color: mui-color('white'); | ||
display: inline-block; | ||
margin: .2rem .2rem .2rem 0; | ||
padding: 0 3px 0 3px; | ||
|
||
.fa-tags { | ||
width: .65rem; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a Cypress test for displaying tags when grouped by author too?