-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2148] Show tags on the ramp chart #2163
[#2148] Show tags on the ramp chart #2163
Conversation
Would it be useful to have the tags direct to the tag page (e.g. https://github.com/reposense/RepoSense/releases/tag/v2.5)? The URLs can be reconstructed from the tag names and the repo URL. |
@jonasongg can you post a screenshot of how the feature appears. I couldn't see any tags in the dashboard preview (I guess the repo we use for the preview doesn't have any tags?). |
@damithc |
@sopa301 that's a great suggestion, thanks! |
Thanks for the screenshot @jonasongg |
@damithc changed the name, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @jonasongg!
Can I check what the behaviour is like if we sort by author, and there's multiple different repositories under the same author? I haven't tested myself, but it seems that the current version will display all the tags (which may be from different repositories) at the top (author) level
@vvidday thanks for spotting this! i changed it such that if we group by author, the tags will appear on the repo (second) level instead. i also made it such that viewing all tags is stored in the url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @jonasongg, definitely agree with the new proposed way of displaying tags when group by author is selected. And great job on adding the state of the toggle to the url!
Have a question about the logic of getting tag links when grouped by author:
…mp-chart' into add-show-tags-on-ramp-chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @jonasongg! I think we can go ahead once we have a test for the group by author case too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a Cypress test for displaying tags when grouped by author too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jonasongg!
As discussed, let us create an issue for the remaining Cypress test required.
The following links are for previewing this pull request:
|
Fixes #2148
Proposed commit message
Other information
Pending changes to documentation and tests!