[⚠️ WIP ⚠️] Api dev #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it allows for all routes in it to be pretended by a string
Move all this stuff to api.py so it is easier to edit and develop
Now make server take the api class from api.py add add to routes
No need to import api because it gets setup in server.py
Fixity those errors
Fix more flake8
PotentialStyx
added
enhancement
Add option to disable prepend in CustomRouteDef, to allow paths not pretended with /api
Python is dumb I forgot to capitalize True
11 tasks
|
Once this is done I think I'll make server into its own "module" and start isolating different parts into like server.api, server.routes, and server.admin, and each can export a route def object, also commonly used functions could be in server.utils @mat-1 @JetStream0 Tho this should prob be finished + merged first |
|
Apparently sub apps are a thing 🤦, adding item to checklist:
I am leaving it unchecked |
Sub-apps are a thing, so I'm switching to do that, the app should use all the base apps properties, so none to set, maybe later we can add api middle ware for token verification tho.
I switched api to be a sub app just making sure it's setup in server.py as well
Fix my dum error, I forgot to specify the subapp path first
Remove that damn extra white space
Add wiki so docs are ezer, I'll turn md to html later This can be used so like https://repldex.com/wiki/api could show api docs
Oof spelling errors, I hate them
|
Any updates? |
Yep, I'm going to yeet this branch and make a new one off of master, then ill apply theese changes to it. Then actually finish it |
|
This is outdated, and changed nothing, a new branch based on master should be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Api changes
progress: