Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanding api & adding tokens #35

Open
1 of 11 tasks
PotentialStyx opened this issue Oct 1, 2020 · 7 comments
Open
1 of 11 tasks

expanding api & adding tokens #35

PotentialStyx opened this issue Oct 1, 2020 · 7 comments
Assignees
Labels
Database Related to the database enhancement New feature or request

Comments

@PotentialStyx
Copy link
Member

PotentialStyx commented Oct 1, 2020

so currently the limited repldex api doesn't have any tokens, and no way to ratelimit, or have restricted access, i suggest that using mongo db to store a token and there permissions, the permissions would be a list with all the permissions, and it would also store meta data in other properties, use as a ratelimit, or if it's request use a cache or not. These could also be controlled thru the admin panel.

checklist:

  • api docs
  • serve api docs on site
  • add tokens
  • store tokens in db
  • token permissions
  • ratelimit's (maybe)
  • more api paths (edit, create entries)
  • api caching
  • non token paths
  • easy permissions extendability
  • admin panel for tokens
@PotentialStyx PotentialStyx self-assigned this Oct 1, 2020
@mat-1
Copy link
Member

mat-1 commented Oct 1, 2020

Imo ratelimits aren't really necessary since not much is being done on the backend when it's used, tokens are annoying, and people could just scrape if they want to bypass the ratelimits anyways.

@mat-1 mat-1 added the enhancement New feature or request label Oct 1, 2020
@PotentialStyx
Copy link
Member Author

Maybe if you don't use a token you get standard access, but using (and getting a token with privilege) can let you do privlaged things like edit, unlist, delete (when added), and modify editors

@PotentialStyx
Copy link
Member Author

Tho highly privlaged tokens (ones with admin features will prob never be given out)

@PotentialStyx
Copy link
Member Author

@JetStream0 doing this here mat1/ReplDex#api-dev

@PotentialStyx PotentialStyx added the Database Related to the database label Oct 14, 2020
@PotentialStyx
Copy link
Member Author

Checklist in #45

@PotentialStyx PotentialStyx mentioned this issue Jan 7, 2021
4 tasks
@PotentialStyx
Copy link
Member Author

Closed #45 becuase it is outdated

@selectdev
Copy link
Contributor

We might add this into v3, not too sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database Related to the database enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants