Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Parser #2716

Open
wants to merge 9 commits into
base: v5
Choose a base branch
from
Open

Command Parser #2716

wants to merge 9 commits into from

Conversation

sjpotter
Copy link
Contributor

Description

Start of implementation of changing how command arguments are transformed to enable easier and more consistent usage across the different clients we have and to enable client side caching.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@sjpotter sjpotter requested a review from leibale March 13, 2024 11:51
}

setCachable() {
this.#cachable = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is cachable "dynamic" (can be either true or false depending on the command arguments)? if not, we should move it from the parser to a constant property on the command.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client = redirectTo;

const chainId = Symbol('Asking Chain');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this fix part of another PR too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants