Cmd parser with commands #2733
Draft
Cmd parser with commands #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivated by wanting to return a read only array from the parser object
sjpotter
force-pushed
the
cmd-parser-with-commands
branch
2 times, most recently
from
3cc3b3b
to
02245f3
Compare
sjpotter
force-pushed
the
cmd-parser-with-commands
branch
from
02245f3
to
93f897d
Compare
…o opt in to that.
update unstableResp3Module flag to only commands that have unstable api add ability to tag commands to ignore user type mapping (as transformReply will convert it to a non typed map type) update bloom info commands to work with new non typed map ability fill in search/time-series commands and tag with unstableResp3Modules flag as appropriate
adjust all usages of it to SimpleStringReply
+ 'fix' for event 'end' test.
enables type mapping of "maps" in resp2 responses that are "fake maps"/mapes in resp3. also enables user configuration of fake maps in resp3 responses (stream message fields).
+ fix things I missed in search
zpopmax (and related) get messed up a by a vsc getter insertion. memory_stats was teting for strings, but inherent DoubleReply are now returned as numbers by default
unsure if this is correct, but everything that is type 'object' will be handled by code as is.
we will always return a typemapped resp3 format, even in resp2. we will not massage the field names to remove the spaces. + handles type mapping of double in resp2 for the one case.
didn't update tests, and got types wrong
didn't like the null prototype for deep equal
1) remove FIRST_KEY_INDEX (As now via pushKeys), but still need something to enumerate if should be on cluster client, so now have a NOT_KEYED_COMMAND 1a) in process saw that not all commands were using pushKey() correctly. 2) fix up usages of parser.pushVariadic() for use only for existing variadic/arrays.. parser.push() can now handle multi element pushes, so don't have to wrap in an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2716