Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 'max' placeholder to latest VS Code 1.83.0 #962

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Bump 'max' placeholder to latest VS Code 1.83.0 #962

merged 1 commit into from
Oct 6, 2023

Conversation

djelinek
Copy link
Collaborator

@djelinek djelinek commented Oct 5, 2023

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek force-pushed the vscode-1.83 branch 3 times, most recently from 2bd561b to c37fa14 Compare October 5, 2023 18:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djelinek djelinek linked an issue Oct 6, 2023 that may be closed by this pull request
[Bug] Workbench().openSettings().findSetting doesnt work on 1.83.0 #964
Closed
3 tasks
@djelinek djelinek marked this pull request as ready for review October 6, 2023 09:44
@djelinek djelinek merged commit 7e4b524 into redhat-developer:main Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Workbench().openSettings().findSetting doesnt work on 1.83.0
1 participant
@djelinek