Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Workbench().openSettings().findSetting doesnt work on 1.83.0 #964

Closed
1 of 3 tasks
EcksDy opened this issue Oct 6, 2023 · 0 comments · Fixed by #962
Closed
1 of 3 tasks

[Bug] Workbench().openSettings().findSetting doesnt work on 1.83.0 #964

EcksDy opened this issue Oct 6, 2023 · 0 comments · Fixed by #962
Assignees
@djelinek
Labels
bug Something isn't working
Milestone
5.10.0

Comments

@EcksDy
Copy link
Contributor

EcksDy commented Oct 6, 2023

The following line finds settings on VSCode 1.71.0, but fails to find anything on 1.83.0.
const setting = await settingsEditor.findSetting(title, ...categories);

Describe the bug

  • Searching for the setting doesn't find it

Steps to Reproduce

  1. Try to search for any nested setting in latest VSCode version

Expected behavior

  • To find the searched setting

Environment information

  • OS:
    • Windows - WSL Ubuntu
    • Linux
    • macOS
  • VSCode version: 1.83.0
  • ExTester version: 5.9.1
  • Node (npm) version: 16.14.2(8.5.0)

Attachments
This is might be related to the "settings search adjustment" introduced in 1.83.0:
https://code.visualstudio.com/updates/v1_83#_settings-editor-search-adjustments
@EcksDy EcksDy added bug Something isn't working new-issue New issue which was not discussed yet labels Oct 6, 2023
@djelinek djelinek self-assigned this Oct 6, 2023
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Oct 6, 2023
@djelinek djelinek added this to the NEXT milestone Oct 6, 2023
@djelinek djelinek linked a pull request Oct 6, 2023 that will close this issue
Bump 'max' placeholder to latest VS Code 1.83.0 #962
Merged
9 tasks
@djelinek djelinek modified the milestones: NEXT, 5.10.0 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djelinek djelinek

Labels
bug Something isn't working
Projects
None yet
Milestone
5.10.0
Development

Successfully merging a pull request may close this issue.

Bump 'max' placeholder to latest VS Code 1.83.0 djelinek/vscode-extension-tester
2 participants
@EcksDy @djelinek