build(deps): bump got from 13.0.0 to 14.2.1 #1197
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [got](https://github.com/sindresorhus/got) from 13.0.0 to 14.2.1. - [Release notes](https://github.com/sindresorhus/got/releases) - [Commits](sindresorhus/got@v13.0.0...v14.2.1) --- updated-dependencies: - dependency-name: got dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
|
@djelinek I think this should be reverted, as Strange that @dependabot did not notice this mismatch. |
|
Hello @DavyLandman thank you for reporting this back! Basically you are right and we can revert to get rid of that warning message during npm install. Few details for the context.
|
|
hi @djelinek I thought that the node 18 dependency was more related to the selenium? since this library is not running inside of VS Code, it doesn't matter "that much" the be on the same version of node as running inside of VS Code right? |
|
Hi, you are right. I have forget to consider also selenium-webdriver NodeJS support policy which is less clear for the current 20+ I will accept your PR, thank you for that 👍🏻 We will be tracking selenium-webdriver and VS Code nodejs support matrix and for now we still have to require NodeJS 18.x |
|
@djelinek great. I hope you don't mind the PR, I was just thinking, instead of only leaving issues & comments, I could try to fix something if I see what has to happen. |
|
every contribution is very welcomed 🙂 ! Thank you for that |
Bumps got from 13.0.0 to 14.2.1.
Release notes
Sourced from got's releases.
Commits
8da991214.2.1c81a611Fix error handling when UTF8 decoding fails (#2336)897f38514.2.04cbd01dAddcauseproperty with the original error toRequestError(#2327)f10e15114.1.05e4f6ffAllow typing the body of aRequestErrorresponse (#2325)382241214.0.08197422Readme tweaksa004263Require Node.js 20 (#2313)7c3f147MakefollowRedirectoption accept a function (#2306)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)