Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted dependabots update to got 14 since it requires node 20 #1252

Merged

Conversation

DavyLandman
Copy link
Contributor

This reverts 20eb715 (#1197)

@dependabot upgraded to got 14, but that now requires node 20. ExTester has just moved to node18 (thanks for that), but as is explained in the readme, it's not ready for node20.

During install of the latest version of extester you would get this message:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=20' },
npm WARN EBADENGINE   current: { node: 'v18.19.1', npm: '10.2.4' }
npm WARN EBADENGINE }

So I thought to help out to make a PR with that dependency reverted, and maybe tell dependabot to not try to update this, the next time it comes around.

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek added the rebase-required Conflicts with main branch, need to rebase label Apr 17, 2024
@djelinek
Copy link
Collaborator

could you please do a rebase on main branch?

@DavyLandman DavyLandman force-pushed the got-node18-downgrade branch from 47217ff to bee6841 Compare April 17, 2024 15:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code and removed rebase-required Conflicts with main branch, need to rebase labels Apr 17, 2024
@djelinek djelinek merged commit 447137f into redhat-developer:main Apr 17, 2024
11 checks passed
@DavyLandman DavyLandman deleted the got-node18-downgrade branch April 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants