-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide basic support for #fragment section #768
Provide basic support for #fragment section #768
Conversation
9784c45
to
f255c67
Compare
f255c67
to
7b56f63
Compare
b88531c
to
ad73c67
Compare
@datho7561 I had had a strange problem. When I execute test on my local machine, I have some trouble (although CI build seems working?) I had to fix https://github.com/redhat-developer/quarkus-ls/pull/768/files#diff-0c6cba217b8d2aafec174ac4005b6f93e7e446f63641556079e995424cb62330 |
For fragment syntax coloration, see redhat-developer/vscode-quarkus#570 |
ad73c67
to
2890b68
Compare
Locally, I have a compilation issue, but I think it's just that I installed a version of lsp4mp that hasn't been published Update: yep, it's just because I had a branch checked out for lsp4mp |
Is this pr works for you @datho7561 ? |
It seems to be working, although I need to test it more thoroughly and look over the code. |
I have the impression that CI build doesnt exe ute QuteHoverInUserTag? |
If you execute QuteHoverInUserTag.java in master you have 2 errors,No? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality seems to be working pretty good, although I found some things in the code.
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/commons/snippets/Link.java
Outdated
Show resolved
Hide resolved
...m.redhat.qute.ls/src/main/java/com/redhat/qute/parser/template/sections/FragmentSection.java
Show resolved
Hide resolved
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/utils/DocumentationUtils.java
Show resolved
Hide resolved
...ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/commons/snippets/SnippetRegistry.java
Outdated
Show resolved
Hide resolved
Wait @angelozerr, do you have test failures with the code that is pushed? I don't have any. |
If I took master, tests fails and I fix with https://github.com/redhat-developer/quarkus-ls/pull/768/files#diff-0c6cba217b8d2aafec174ac4005b6f93e7e446f63641556079e995424cb62330 which is out of the scope of this PR. |
If I check out |
8a523f5
to
497bc71
Compare
The 2 tests fails because those tests are wrong, the documentation should show Javadoc from field. In master the Javadoc is not included. It is my fix. |
497bc71
to
3370df6
Compare
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well. Thanks, Angelo!
Provide basic support for #fragment section
This PR provides
#fragment
snippet completionSee redhat-developer/vscode-quarkus#563
Signed-off-by: azerr [email protected]