Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute is now supporting fragments #563

Open
ia3andy opened this issue Dec 7, 2022 · 14 comments
Open

Qute is now supporting fragments #563

ia3andy opened this issue Dec 7, 2022 · 14 comments
Assignees
Labels
enhancement New feature or request qute

Comments

@ia3andy
Copy link

ia3andy commented Dec 7, 2022

image

image

It seems VSCode extension doesn't support this yet.

See https://quarkus.io/guides/qute-reference#fragments

cc @mkouba

@angelozerr
Copy link
Contributor

Thanks for reporting this issue. We need to implement it.

@ia3andy
Copy link
Author

ia3andy commented Dec 7, 2022

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

@fbricon
Copy link
Collaborator

fbricon commented Dec 7, 2022

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

Yes they should :-)

@mkouba
Copy link
Collaborator

mkouba commented Dec 7, 2022

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

Unfortunately, there is no sync process at the moment. I believe that we should just file a new issue here when a new feature lands in the main branch?

FTR Type-safe Fragments: https://quarkus.io/guides/qute-reference#type_safe_fragments

@ia3andy
Copy link
Author

ia3andy commented Dec 7, 2022

@fbricon if we create an issue here, is this synced in the team for all IDEs plugins?

@fbricon
Copy link
Collaborator

fbricon commented Dec 7, 2022

If the work only involves development on the https://github.com/redhat-developer/quarkus-ls side, then all IDEs will automatically reap the benefits. VS Code is the 1st consumer, Eclipse and IntelliJ will pick it up eventually.
Anything that involves custom UI work, exposing settings and whatnot, requires custom client development. If @jeffmaury follows changes on the quarkus-ls repo, I think he should be able to follow up on the Eclipse and IntelliJ side of things on his own. Else we'll give him a nudge ;-)

@angelozerr
Copy link
Contributor

For fragment it will require some work on JDT LS side, so @jeffmaury will need to do the same thing for IJ.

I have the intention to work on this issue.

@angelozerr angelozerr self-assigned this Dec 7, 2022
@angelozerr
Copy link
Contributor

@ia3andy in your sample I have the impression that when you write $ in method of TemplateInstance it defines the fragment id (noteList). Is it corect?

I have not found some documentation which explains that in https://quarkus.io/guides/qute-reference#fragments

Which support of fragment are you expecting?

@mkouba
Copy link
Collaborator

mkouba commented Jan 16, 2023

I have not found some documentation which explains that in https://quarkus.io/guides/qute-reference#fragments

I believe that this is documented in the Type-safe Fragments section (it's a quarkus-specific feature).

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
@angelozerr
Copy link
Contributor

angelozerr commented Jan 16, 2023

I believe that this is documented in the Type-safe Fragments section (it's a quarkus-specific feature).

Thanks for your clarification @mkouba

I started the support of fragment with redhat-developer/quarkus-ls#768

You can notice that cmpletion, hover of section show now link(s) of the documentation

image

It will avoid for newbie (like me) to forget some part of documentation.

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 16, 2023
@angelozerr
Copy link
Contributor

@ia3andy is it possible to share your project with fragment please, in order to that I play with it. Thanks.

@datho7561 datho7561 added enhancement New feature or request qute labels Jan 16, 2023
datho7561 pushed a commit that referenced this issue Jan 16, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 17, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 17, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 17, 2023
datho7561 pushed a commit to redhat-developer/quarkus-ls that referenced this issue Jan 17, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 18, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 18, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 18, 2023
@angelozerr
Copy link
Contributor

@mkouba @ia3andy you can see a demo with my current work for fragment support at redhat-developer/quarkus-ls#769 (comment)

Please add comments in this PR if you need some improvement , another features for fragment support, etc. Thanks.

@ia3andy
Copy link
Author

ia3andy commented Jan 18, 2023

@angelozerr sorry for the delay, here is the project: https://github.com/ia3andy/renotes/

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 19, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 19, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 19, 2023
@angelozerr
Copy link
Contributor

@angelozerr sorry for the delay, here is the project: https://github.com/ia3andy/renotes/

Thanks so much @ia3andy I will try with your project to see if there are not some usecases that I could miss.

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 20, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 20, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 20, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 20, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 23, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 23, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 23, 2023
datho7561 pushed a commit to redhat-developer/quarkus-ls that referenced this issue Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qute
Projects
None yet
Development

No branches or pull requests

5 participants